Do I need improvements in this routine?

Printable View